On pe, 2017-03-10 at 08:28 -0800, Oscar Mateo wrote: > Some recent refactoring patches have left the doorbell creation outside > the GuC client allocation, which does not make a lot of sense (a client > without a doorbell is something useless). Move it back there, and > refactor the init_doorbell_hw consequently. > > Thanks to this, we can do some other improvements, like hoisting the > check for GuC submission enabled out of the enable function. > > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > Cc: Michal Wajdeczko <michal.wajdec...@intel.com> > Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospu...@intel.com> > Signed-off-by: Oscar Mateo <oscar.ma...@intel.com>
Looks good. Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx