On Sun, Jun 17, 2012 at 09:18:56PM +0200, Paul Menzel wrote: > Dear Thomas, > > > you put Daniel address twice into the CC field. > > > Am Sonntag, den 17.06.2012, 20:59 +0200 schrieb Thomas Richter: > > Includes now proper DPMS support. > > Includes switching between resolutions - from 640x480 to 1024x768. > > Currently assumes that the native display resolution is 1024x768. > > Please put that after the next paragraph. > > > The ns2501 seems to be rather critical - if the output PLL is not > > running, the chip doesn't seem to be clocked and then doesn't react > > on i2c messages. Thus, a quick'n-dirty trick ensures that the DVO > > is active before submitting any i2c messages to it. This is > > probably to be reviewed. > > Such for the commit message unnecessary information goes below the first > `---` below.
Fully disagree, this explains why the patch exports a function from intel_display.c and hence _must_ be part of the commit message. While you resend, can you also please add bug links to the s-o-b section of your patch? > > Signed-Off-by: Thomas Richter <t...@math.tu-berlin.de> > > --- > > Here goes email message information. > > > drivers/gpu/drm/i915/Makefile | 1 + > > drivers/gpu/drm/i915/dvo.h | 1 + > > drivers/gpu/drm/i915/dvo_ns2501.c | 566 > > ++++++++++++++++++++++++++++++++++ > > Unfortunately you have to resend as v4 since your mailer line wrapped > this line and others. Yeah, patch is corrupted, I guess the easiest thing is to simply append the file generated with format-patch - I can also slurp that one in. Thanks, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
