On ma, 2017-02-13 at 12:48 +0200, Joonas Lahtinen wrote:
> On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote:
> > -static inline int fault_in_pages_writeable(char __user *uaddr, int size)
> > +static inline int fault_in_pages_writeable(char __user *uaddr,
> > +                                      unsigned long size)
> >  {
> >     char __user *end = uaddr + size - 1;
> 
> ptrdiff_t would be more appropriate for both functions. With those and
> correct "From:", this is;

Actually, size_t would be more appropriate, I don't think anybody is
using those negative values.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to