On Mon, 02 Jan 2017, Madhav Chauhan <madhav.chau...@intel.com> wrote:
> From: Deepak M <m.dee...@intel.com>
>
> Dual link Z-inversion overlap field is present
> in MIPI_CTRL register unlike the older platforms,
> hence setting the same in this patch.
>
> Signed-off-by: Deepak M <m.dee...@intel.com>
> Signed-off-by: Madhav Chauhan <madhav.chau...@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dsi.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c 
> b/drivers/gpu/drm/i915/intel_dsi.c
> index 3ae70ae..95a6cad 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -558,12 +558,21 @@ static void intel_dsi_port_enable(struct intel_encoder 
> *encoder)
>  
>       if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK) {
>               u32 temp;
> -
> -             temp = I915_READ(VLV_CHICKEN_3);
> -             temp &= ~PIXEL_OVERLAP_CNT_MASK |
> +             if (IS_GEN9_LP(dev_priv)) {
> +                     for_each_dsi_port(port, intel_dsi->ports) {
> +                             temp = I915_READ(MIPI_CTRL(port));
> +                             temp &= ~BXT_PIXEL_OVERLAP_CNT_MASK |
> +                                     intel_dsi->pixel_overlap <<
> +                                     BXT_PIXEL_OVERLAP_CNT_SHIFT;
> +                             I915_WRITE(MIPI_CTRL(port), temp);

I think I'd do this where MIPI_CTRL is updated. If we set
->pixel_overlap to 0 for intel_dsi->dual_link !=
DSI_DUAL_LINK_FRONT_BACK in vbt_panel_init(), we can just write it
instead of checking dual_link.

BR,
Jani.

> +                     }
> +             } else {
> +                     temp = I915_READ(VLV_CHICKEN_3);
> +                     temp &= ~PIXEL_OVERLAP_CNT_MASK |
>                                       intel_dsi->pixel_overlap <<
>                                       PIXEL_OVERLAP_CNT_SHIFT;
> -             I915_WRITE(VLV_CHICKEN_3, temp);
> +                     I915_WRITE(VLV_CHICKEN_3, temp);
> +             }
>       }
>  
>       for_each_dsi_port(port, intel_dsi->ports) {

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to