On 05/09/2012 09:34 PM, Paulo Zanoni wrote:
2012/5/9 Eugeni Dodonov<eugeni.dodo...@intel.com>:
Haswell has different DIP control registers and offsets which we need to
use for infoframes, which this patch adds.

Note that this does not adds full DIP frames support, but only the basic
functionality necessary for HDMI to work in early enablement.

Signed-off-by: Eugeni Dodonov<eugeni.dodo...@intel.com>
---

Hi

The i915_reg.h chunk seems correct, but I believe hsw_write_infoframe
is wrong. The DIP control register completely changed, and the way we
write the infoframes has also changed. Previously, we had just one
"data" register for the full 32-byte buffer and we controlled which
part of the buffer we wanted to write by the last 4 bits of the
"control" register. These last 4 bits on the control register don't
exist anymore (the whole register changed) and we have a ton of "data"
registers now. I didn't test anything I wrote here, I'm just assuming
based on the docs I have :)

For basic HDMI enablement this function is not strictly necessary, so
maybe just adding a FIXME (like you did) and returning without doing
anything would be fine. I'm going to provide a patch for this.

(Just following up on what we discussed with Paulo over irc).

Without this, I am getting a nice black screen though . But the latest theory is that perhaps we just need to send any infoframe for the hardware to catch up and work in HDMI mode?

Eugeni
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to