The function name gen8_setup_page_directory is misleading, and only
serves to confuse the reader, it's not setting up a pd, but rather
encoding a specific pdpe with a given pd.

Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index ef00d36680c9..62b6a6b69efe 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -626,10 +626,10 @@ static void gen8_initialize_pml4(struct 
i915_address_space *vm,
 }
 
 static void
-gen8_setup_page_directory(struct i915_hw_ppgtt *ppgtt,
-                         struct i915_page_directory_pointer *pdp,
-                         struct i915_page_directory *pd,
-                         int index)
+gen8_setup_pdpe(struct i915_hw_ppgtt *ppgtt,
+               struct i915_page_directory_pointer *pdp,
+               struct i915_page_directory *pd,
+               int index)
 {
        gen8_ppgtt_pdpe_t *page_directorypo;
 
@@ -1375,7 +1375,7 @@ static int gen8_alloc_va_range_3lvl(struct 
i915_address_space *vm,
 
                kunmap_px(ppgtt, page_directory);
                __set_bit(pdpe, pdp->used_pdpes);
-               gen8_setup_page_directory(ppgtt, pdp, pd, pdpe);
+               gen8_setup_pdpe(ppgtt, pdp, pd, pdpe);
        }
 
        free_gen8_temp_bitmaps(new_page_dirs, new_page_tables);
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to