[Intel-gfx] [PATCH 2/2] intel: Detect cache domain inconsistency with valgrind

[Chris Wilson]

Every access to either the GTT or CPU pointer is supposed to be
proceeded by a set_domain ioctl so that GEM is able to manage the cache
domains correctly and for the following access to be coherent. Of
course, some people explicitly want incoherent, non-blocking access
which is going to trigger warnings by this patch but are probably better
served by explicit suppression.

Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
 intel/intel_bufmgr_gem.c |   22 ++++++++++++++++++++++
 1 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c
index 4d30e62..d40f2cd 100644
--- a/intel/intel_bufmgr_gem.c
+++ b/intel/intel_bufmgr_gem.c
@@ -1098,6 +1098,20 @@ static void drm_intel_gem_bo_unreference(drm_intel_bo 
*bo)
        }
 }
 
+static void
+drm_intel_gem_bo_mark_mmaps_incoherent(drm_intel_bo *bo)
+{
+#if HAVE_VALGRIND
+       drm_intel_bo_gem *bo_gem = (drm_intel_bo_gem *) bo;
+
+       if (bo_gem->mem_virtual)
+               VALGRIND_MAKE_MEM_NOACCESS(bo_gem->mem_virtual, bo->size);
+
+       if (bo_gem->gtt_virtual)
+               VALGRIND_MAKE_MEM_NOACCESS(bo_gem->gtt_virtual, bo->size);
+#endif
+}
+
 static int drm_intel_gem_bo_map(drm_intel_bo *bo, int write_enable)
 {
        drm_intel_bufmgr_gem *bufmgr_gem = (drm_intel_bufmgr_gem *) bo->bufmgr;
@@ -1159,6 +1173,8 @@ static int drm_intel_gem_bo_map(drm_intel_bo *bo, int 
write_enable)
        if (write_enable)
                bo_gem->mapped_cpu_write = true;
 
+       drm_intel_gem_bo_mark_mmaps_incoherent(bo);
+       VALGRIND_MAKE_MEM_DEFINED(bo_gem->mem_virtual, bo->size);
        pthread_mutex_unlock(&bufmgr_gem->lock);
 
        return 0;
@@ -1239,6 +1255,8 @@ int drm_intel_gem_bo_map_gtt(drm_intel_bo *bo)
                    strerror(errno));
        }
 
+       drm_intel_gem_bo_mark_mmaps_incoherent(bo);
+       VALGRIND_MAKE_MEM_DEFINED(bo_gem->gtt_virtual, bo->size);
        pthread_mutex_unlock(&bufmgr_gem->lock);
 
        return 0;
@@ -1614,6 +1632,8 @@ drm_intel_gem_bo_process_reloc(drm_intel_bo *bo)
                if (target_bo == bo)
                        continue;
 
+               drm_intel_gem_bo_mark_mmaps_incoherent(bo);
+
                /* Continue walking the tree depth-first. */
                drm_intel_gem_bo_process_reloc(target_bo);
 
@@ -1638,6 +1658,8 @@ drm_intel_gem_bo_process_reloc2(drm_intel_bo *bo)
                if (target_bo == bo)
                        continue;
 
+               drm_intel_gem_bo_mark_mmaps_incoherent(bo);
+
                /* Continue walking the tree depth-first. */
                drm_intel_gem_bo_process_reloc2(target_bo);
 
-- 
1.7.9

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx