On Wed, 02 Nov 2011 09:12:13 +0000, Chris Wilson <ch...@chris-wilson.co.uk> wrote:
> This would seem to be a separate chunk to initiate training on only the > lanes we intend to use. > -Chris Here's that patch separated out: commit e7fecae483754ca9a42312be18f58ceb454702fe Author: Keith Packard <kei...@keithp.com> Date: Wed Nov 2 10:17:59 2011 -0700 drm/i915: Initiate DP link training only on the lanes we'll be using Limit the link training setting command to the lanes needed for the current mode. It seems vaguely possible that a monitor will try to train the other lanes and fail in some way, so this seems like the safer plan. Signed-off-by: Keith Packard <kei...@keithp.com> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 0a4fa64..02b56ce 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -1567,8 +1567,9 @@ intel_dp_set_link_train(struct intel_dp *intel_dp, ret = intel_dp_aux_native_write(intel_dp, DP_TRAINING_LANE0_SET, - intel_dp->train_set, 4); - if (ret != 4) + intel_dp->train_set, + intel_dp->lane_count); + if (ret != intel_dp->lane_count) return false; return true; -- keith.pack...@intel.com
pgpgojGia4B3D.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx