On Thu, Oct 13, 2011 at 01:00:02PM +0100, Chris Wilson wrote:
> On Thu, 13 Oct 2011 10:58:25 +0200, Daniel Vetter <dan...@ffwll.ch> wrote:
> > On Wed, Oct 12, 2011 at 03:56:22PM -0700, Ben Widawsky wrote:
> > > This refactor is useful for some future work I'll be doing on the
> > > execbuffer path. In addition to being a pretty easy prerequisite, it
> > > also helped me track down the bug uncovered in the first patch.
> > >
> > > Signed-off-by: Ben Widawsky <b...@bwidawsk.net>
> > > ---
> > > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 102
> > > ++++++++++++++--------------
> > > 1 files changed, 51 insertions(+), 51 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > index 182a2b9..b3beaae 100644
> > > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> > > @@ -40,6 +40,16 @@ struct change_domains {
> > > uint32_t flips;
> > > };
> > >
> > > +struct eb_objects {
> > > + struct drm_i915_gem_object *batch_obj;
> > > + struct list_head objects;
> > > + int buffer_count;
> > > + int mode;
> > > + int and;
> >
> > While you whack this code, can you do an s/and/end, I think that's just a
> > typo ...
>
> It was meant to be 'and' since it was the value of the mask I was anding
> with. I'm sorry I appear to have spent too much time inside the Xserver,
> end = and + 1.
Indeed, maybe s/and/hash_mask/?
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 48
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
