On Mon, Jan 31, 2011 at 06:22:37 +0100, Cyril Brulebois wrote: > Get rid of those accordingly with CFLAGS="-Wall -Werror": > | CC i915_xvmc.lo > | cc1: warnings being treated as errors > | i915_xvmc.c: In function ‘i915_mc_one_time_state_emit’: > | i915_xvmc.c:369: error: suggest parentheses around arithmetic in operand of > ‘|’ > | i915_xvmc.c:374: error: suggest parentheses around arithmetic in operand of > ‘|’ > | i915_xvmc.c:379: error: suggest parentheses around arithmetic in operand of > ‘|’ > | i915_xvmc.c: In function ‘i915_mc_load_indirect_render_emit’: > | i915_xvmc.c:708: error: suggest parentheses around arithmetic in operand of > ‘|’ > | i915_xvmc.c:713: error: suggest parentheses around arithmetic in operand of > ‘|’ > > Signed-off-by: Cyril Brulebois <k...@debian.org> > --- > src/xvmc/i915_xvmc.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > Could do:
diff --git a/src/xvmc/intel_batchbuffer.h b/src/xvmc/intel_batchbuffer.h index 6fa1c05..ceb328c 100644 --- a/src/xvmc/intel_batchbuffer.h +++ b/src/xvmc/intel_batchbuffer.h @@ -24,7 +24,7 @@ extern int VERBOSE; #define OUT_RELOC(bo,read_domains,write_domains,delta) \ do { \ - *(unsigned int *)batch_ptr = delta + bo->offset; \ + *(unsigned int *)batch_ptr = (delta) + (bo)->offset; \ intel_batch_emit_reloc(bo, read_domains, write_domains, delta, batch_ptr); \ batch_ptr += 4; \ } while (0) instead? Cheers, Julien
signature.asc
Description: Digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx