On Tue, 28 Sep 2010 16:12:16 -0700, Simon Que <s...@chromium.org> wrote: > Hi all, > > I have updated the patch containing the dither bit change and VBT > default settings. This time, all default values have been moved to a > single function, init_vbt_defaults. This function is called from > intel_init_bios before checking for VBT. Hence, it is used in both > the VBT found and VBT not found cases. > > The parse functions previously contained VBT default values for the > case where VBT was found -- those have been moved to the new function > init_vbt_defaults. This new arrangement reduces code redundancy (no > need to set dither bit in two places) and consolidates all default > settings into one place.
Looks very good. Just one minor niggle... It makes life much easier if the patch is in a format digestible by git am. Can you please rebase this against drm-intel-next (git://git.kernel.org/pub/scm/linux/kernel/git/ickle/drm-intel.git) and regenerate the patch using git format-patch or git send-email? Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
