On Tue, 2010-08-24 at 09:42 +0100, Chris Wilson wrote:
> This looks to be a useful set of patches that enable VBT parsing on
> machines with only a compressed VBIOS and so provide fixed-panel modes
> for my netbooks. In conjunction with this, I then hit an issue where the
> BIOS writers became creative in their use of VBT and so I needed a small
> patch to lvds_is_present_in_vbt() to account for the new brain damage.
> After Adam's insight, we just accept the VBT without question if it came
> from OpRegion.

I'd be a little more comfortable with this series if we tried to find
VBT in VBIOS first.  The way around you have it in patch 3 we'll likely
be changing behaviour on existing machines, since we've not been paying
any attention to what OpRegion's VBT contains before now.  I mean, I'm
not going to insist on it, but I'll reserve the right to say I told you
so.

But either way, for the series:

Reviewed-by: Adam Jackson <a...@redhat.com>

- ajax

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to