On Wed, May 19, 2010 at 05:33:28PM +0800, Zou Nan hai wrote: > The patch series try to abstruct ring buffer > structure, implement BSD (bit stream decoder) ring > buffer for H.264/VC1 VLD decoding. > > I mark this as V1 for review.
Woot, we're (slowly) getting there. I'll do an in-depth review some when later this week (running short on free time, atm). On a quick look, the series has definitely improved. One nitpick up-front: You haven't sent the individual patches as follow-ups to the introduction email. Just use git format-patch and git send-email, they'll take care of all the boring details for you. Quick primer, if you're totally lazy: $ git format-patch --cover-letter -o output_directory revision_range creates a bunch of .patch files including introduction letter with the commits int the given range. You only have to change the subject & text of the cover letter. Then $ git send-email --to 'b...@bla.com' --cc 'f...@bar.com' *.patch [--dry-run] sends them away. Use --dry-run to check first that git does the right thing with your patches. Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
