Hi all, These are the last two patches of my original series. I've re-rechecked, and contrary to what I've said on irc, the linux build system can't cope with a module that consists of multiple source files, one of which is named identical (minus suffix) to the module. I nicely barfs while compiling with the following error:
make[3]: Circular drivers/char/agp/intel-agp.o <- drivers/char/agp/intel-agp.o dependency dropped. So yes, kbuild is indeed "a pile of failure". Instead of moving around intel-agp.c (which creates unnecessary merge conflicts), I've decided to create a new modules for intel-gtt.c. Changes boot-tested on my i855. Patches rebased against drm-next due to conflicts with Dave's small fix to the probe code. Please review and merge. Thanks, Daniel Daniel Vetter (2): agp/intel: split out gmch/gtt probe, part 2 agp/intel: make intel-gtt.c into a real source file drivers/char/agp/Makefile | 1 + drivers/char/agp/intel-agp.c | 181 ++++++------------------------------------ drivers/char/agp/intel-agp.h | 4 + drivers/char/agp/intel-gtt.c | 128 +++++++++++++++++++++++++++++ 4 files changed, 156 insertions(+), 158 deletions(-) _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
