Wow thanks a lot for the Suggestions, You actually took some time to review the Code !!
#1 : Sorry for committing .swp and .pyc files , I am new to Git , so i am just now getting the hang of it . Will try to remove it in the next Commit #2 : I plan to release it Under Gnu GPL , but any Suggestions on that are welcome. #3 : Ya sure Will Add it in the next Commit #4 : I was actually in a Hurry to get this up and Running , I Have another main Project , This was done during a break and I had Less than 12 hrs to come with the idea , Implement it , and check if it works . #5 : Actually I designed it using Json. but GAE doesn't have a Json encoder as its using Python 2.5 , But I forgot that I can import Simple Json so thats why I put it in the Repo , I'll add Json Support in the next Commit #6 : Ya I agree , I have to do that , When I am coding html , JavaScript , and python , I seriously get confused with naming standards . On 17 June 2011 11:37, Shakthi Kannan <[email protected]> wrote: > Hi, > > --- On Fri, Jun 17, 2011 at 7:23 AM, Gautam <[email protected]> wrote: > | I have Uploaded the Source Code at > | > | https://github.com/gautamk/FFDownloadComplete > \-- > > Quick thoughts: > > #001 Why do you commit .swp and .pyc files? Git only tracks changes in > content. > > #002 Add a LICENSE file indicating the license under which the sources > are released. > > #003 Add a copyright, header notice in each source file. > > #004 Run pylint on your *.py and fix the warning/error messages. > > #005 Any reason to have not used json? You have commented its import > in python/register.py > > http://docs.python.org/library/json.html > > #006 Please follow PEP8 guidelines. For example: "class names use the > CapWords convention". Try to be consistent across your source files. > > http://www.python.org/dev/peps/pep-0008/ > > SK > > -- > Shakthi Kannan > http://www.shakthimaan.com > _______________________________________________ > ILUGC Mailing List: > http://www.ae.iitm.ac.in/mailman/listinfo/ilugc > _______________________________________________ ILUGC Mailing List: http://www.ae.iitm.ac.in/mailman/listinfo/ilugc
