On Thu, 21 Nov 2024 21:23:52 GMT, Phil Race <p...@openjdk.org> wrote:

> This removes uses of AccessControlContext in java.desktop

I think the removal of the use of the `AccessControlException` should also be 
part of this PR.

there is only one usage:

./src/java.desktop/share/classes/java/awt/Dialog.java:36:import 
java.security.AccessControlException;
./src/java.desktop/share/classes/java/awt/Dialog.java:1597:        } catch 
(@SuppressWarnings("removal") AccessControlException ace) {
``` 

And it seems that the `java.awt.Dialog#checkModalityPermission()` has became 
obsolete.

src/java.desktop/share/classes/java/awt/Component.java line 8949:

> 8947:     private void readObject(ObjectInputStream s)
> 8948:       throws ClassNotFoundException, IOException
> 8949:     {

`@SuppressWarnings("removal")` can be removed

src/java.desktop/share/classes/java/awt/MenuComponent.java line 428:

> 426:     private void readObject(ObjectInputStream s)
> 427:         throws ClassNotFoundException, IOException, HeadlessException
> 428:     {

`@SuppressWarnings("removal")` can be removed

src/java.desktop/share/classes/javax/swing/UIDefaults.java line 1116:

> 1114:          *              parameters to the static method in class c
> 1115:          */
> 1116:         @SuppressWarnings("removal")

Suggestion:

-------------

PR Review: https://git.openjdk.org/jdk/pull/22308#pullrequestreview-2453047414
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853110063
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853117233
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853123036

Reply via email to