On Tue, 29 Aug 2023 18:41:05 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Andrey Turbanov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8312165: Fix typos in java.desktop Swing >> >> apply suggestions from review >> - 8312165: Fix typos in java.desktop Swing >> >> revert changes from non-swing parts to minimize count of files to review > > src/java.desktop/share/classes/javax/swing/text/DefaultFormatter.java line 1: > >> 1: /* > > Perhaps, we should leave **“overwrite”** only. A *strike-through* means a > line drawn over the text, ~~like this~~. I hardly understand what > *“overstrike”* means, see the `setOverwriteMode` method: > > https://github.com/openjdk/jdk/blob/e22762c010e5cd4c313e5f2816b67d75862935a7/src/java.desktop/share/classes/javax/swing/text/DefaultFormatter.java#L162-L164 > > As far as I understand, it refers to the **overwrite mode** when typed > characters aren't inserted but instead they replace the characters present in > the text. > > To clarify the meaning, > > * @param overwriteMode Indicates if overwrite or overstrike mode is used > */ > public void setOverwriteMode(boolean overwriteMode) { I agree. Changed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14847#discussion_r1309871095
