On Wed, 14 Jun 2023 17:20:31 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> test/jdk/java/nio/charset/Charset/Contains.java line 108:
>> 
>>> 106:     }
>>> 107: 
>>> 108:     static void selfContainmentTest() {
>> 
>> Be nice to add a comment regarding the purpose of the test
>
> The spec is that Charset::contains return true for self so maybe it could be 
> renamed to containsSelfTest, might help with the understanding the purpose 
> (along with a comment)

Good point. Will address these in the next iteration

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14473#discussion_r1229964387

Reply via email to