Re: RFR: 8271603: Unnecessary Vector usage in java.desktop [v4]

[Andrey Turbanov]

On Fri, 27 Aug 2021 17:04:33 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> Andrey Turbanov has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   8271603: Unnecessary Vector usage in java.desktop
>>   migrate even more usages
>
> src/java.desktop/share/classes/javax/swing/JMenu.java line 1340:
> 
>> 1338:         }
>> 1339:         MenuElement[] me = new MenuElement[elements.size()];
>> 1340:         elements.toArray(me);
> 
> Implementation of the "toArray([])" is not equivalent of "copyInto([])". 
> Maybe no-arg "return elements.toArray()" will look better. Same comment about 
> other removed usage of copyInto

Can you please elaborate?
As I can see if size of array is exactly the same as size of vector/arraylist, 
implementations are similar - they just call System.arraycopy
![изображение](https://user-images.githubusercontent.com/741251/131168809-480c05d6-2775-4812-91f5-c73833f9a396.png)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4680