On Wed, 23 Jun 2021 16:35:30 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Hi Naoto, I decided to only introduce the`instanceof` pattern variable where >> I thought it would add additional value to the code. In situations like this >> one, I thought there wasn't much point as the cast variable is only used >> once (in the switch). However, if you think I've overlooked something that >> would be beneficial to change, I'd be happy to take a look. > > I'd personally replace all the applicable locations, as otherwise, it would > confuse why there are two idioms. But it is outside of this PR so probably > for another day. I agree with Naoto that it's a bit strange. ------------- PR: https://git.openjdk.java.net/jdk/pull/4552
