On Tue, 25 May 2021 16:40:53 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Please review the fix. The issue was informed yesterday by @amaembo that it > offends some code analysis tools. > Although the fix is to change the condition error, it turned out that > `JapaneseImperialCalendar.roll()` did not work for `WEEK_OF_MONTH` and > `DAY_OF_MONTH`. There was an inherent issue where `GregorianCalendar` does > not follow the `roll()` spec, i.e., "The MONTH must not change when the > WEEK_OF_MONTH is rolled." during the Julian/Gregorian transition. JDK-6191841 > seems to have tried to fix it but it was closed as `Future Project`... > So I simply fixed the `roll()` issue in `JapaneseImperialCalendar` to follow > the spec here, which seems to be the intent of the original author. Marked as reviewed by joehw (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/4191
