On Mon, 24 May 2021 13:44:36 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using >> IntelliJ IDEA refactoring. Some manual adjustments are also performed, >> including indentations, moving comments, extracting common cast out of >> switch expression branches, etc. >> >> I also noticed that there are some switches having one branch only in >> JapaneseImperialCalendar.java. Probably it would be better to replace them >> with `if` statement? > > src/java.base/share/classes/java/util/regex/CharPredicates.java line 217: > >> 215: case "WORD" -> WORD(); >> 216: default -> null; >> 217: }; > > This file has lots of changes which are difficult to review. Maybe it should > be split out of this PR. *sigh* GitHub diff tool is really poor and outdated. Here's how it looks in IntelliJ IDEA diff view:  ------------- PR: https://git.openjdk.java.net/jdk/pull/4161
