On Mon, 8 Feb 2021 17:40:00 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> This patch refactor JDK internal charsets to initialize charset mapping data 
>> lazily when needed via holder classes. This means both a startup improvement 
>> in some cases, and possible throughput improvements for all DoubleByte-based 
>> Charsets.
>> 
>> Testing: tier1-3
>
> Looks good to me. I initially thought of the same impression as Alan's, i.e., 
> enumerating all charsets is not that common (in fact, same applies to Locale, 
> and I once explored usages and it ended all up in test cases), but if real 
> apps are using it, this is the right way to do so.

Thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2449

Reply via email to