Hi Naoto,
I don't seem to see the DateFormat class or the getDateInstance methods
specify how errors may be handled (or logged). Is that stated somewhere
else? In other cases, I see that you've changed it to throw
ServiceConfigurationError, that looks to me may be better than a log as
a configuration error (or specifying wrong provider) sounds to me more
severe than info.
Of the three HostLocaleProviderAdapterImpl, the one for unix is deleted,
is there a specific reason?
Best,
Joe
On 5/20/2020 10:29 AM, naoto.s...@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8245241
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8245241/webrev.00/
Incorrect user-provided provider preference is supposed to be logged.
However it is not so because it is using
PlatformLogger(SurrogateLogger) which uses the default logging level.
I changed it to use j.l.System's logger and bumped it to INFO level
(it should notify the user by default). By taking this opportunity, I
did some clean-up in locale provider adapter's logging related code as
well.
Naoto
