Hi Naoto,

The existing tests verifies that a display name matches an expected value. I wonder if you'd want to do a bit more than the Boolean assertion with a similar approach as the existing test, that is, check that the fallback values/alias names match expected names.

Best,
Joe


On 3/13/20 1:25 PM, naoto.s...@oracle.com wrote:
Hello,

Please review the fix to the following issue:

https://bugs.openjdk.java.net/browse/JDK-8240626

The proposed chageset is located at:

https://cr.openjdk.java.net/~naoto/8240626/webrev.00/

In some locales, CLDR only provides partial translations of era names, e.g., only HEISEI and REIWA are provided for Japanese Calendar in Greek locale. CLDRConverter needs to supplement those missing translations from parent locales.

Naoto

Reply via email to