On 11/07/2019 07:37, Dmitry Cherepanov wrote:
> Looks good to me.
>
> One suggestion: does it make sense to include additional change in
> ZoneInfoFile.java to address the comment [1] in 8u too, it was fixed in the
> final patch for jdk/jdk13 [2].
>
> Thanks,
>
> Dmitry
>
> [1]
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-July/061216.html
> [2] https://hg.openjdk.java.net/jdk/jdk13/rev/8df81df1cce4#l13.1
>
Yeah, my original post was based on the original webrev I reviewed prior
to that comment being made, and the final commit.
Here's an updated version based on the final commit, which I'm also
including in 8u222:
https://cr.openjdk.java.net/~andrew/openjdk8/8224560/webrev.02/
Thanks,
--
Andrew :)
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew
