Hi Deepak, Minor, but it will be good if you change the test case name to something like TestPeruDecimalFormat.java or TestPeruCurrencyDecimalFormat instead of just using BugID.
Regards, Ramanand. -----Original Message----- From: Naoto Sato Sent: Friday, May 10, 2019 6:12 PM To: Deepak Kejriwal <deepak.kejri...@oracle.com>; i18n-dev@openjdk.java.net; core-libs-...@openjdk.java.net Subject: Re: <i18n dev> [13] RFR: JDK-8206879: Currency decimal marker incorrect for Peru Hi Deepak, here are my comments. - FormatData_es_PE.java: Modify the copyright year to 2019. - Changes in "LocaleData" may be placed at the bottom of the file, explicitly indicating it is changed with 8206879. Please follow the similar changes' format. - Bug8206879.java does not have proper copyright header. Naoto On 5/10/19 4:25 AM, Deepak Kejriwal wrote: > Hello, > > > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8206879 > > > > The proposed fix is located at: > > http://cr.openjdk.java.net/~dkejriwal/8206879/webrev.00/ > > > > Summary > > In case of JRE locale provider, for Peru comma (,) is used as decimal marker > which is incorrect. The fix is to correct decimal marker for Peru from comma > (,) to dot (.). > > > > Regard, > > Deepak > > >
