Hi Nishit,

Looks good to me.

One minor typo: Bundle.java:line 699 "SimpledateFormat" -> "SimpleDateFormat". No further review is needed for this.

Naoto

On 2/22/19 5:18 AM, Nishit Jain wrote:
Hi,

Please review the fix for JDK-8209175

Bug: https://bugs.openjdk.java.net/browse/JDK-8209175
Webrev: http://cr.openjdk.java.net/~nishjain/8209175/webrev.03/


Issue: In CLDR 33 update, 'B' character has been added in date time patterns for Burmese locale, which is used to represent the day period. This character is not supported in DateTimeFormatter or SimpleDateFormat APIs, so an exception is thrown that an "unknown character is encountered"

Fix: A workaround is added in which 'B' character appearing in CLDR date-time pattern is replaced with 'a' character and hence resolved with am/pm strings. This is based on the LDML specification given for 'B' character in which it falls back to 'a' character if it is not supported by any locale.


Regards,
Nishit Jain

Reply via email to