On 23/05/2016 07:11, Masayoshi Okutsu wrote:
Hi,

Please review changes for JDK-8031145 that is to open closed i18n tests. There are many old tests which should be cleaned up. I did some, but there are still many.

Issue:
https://bugs.openjdk.java.net/browse/JDK-8031145

Webrev:
http://cr.openjdk.java.net/~okutsu/9/8031145/webrev.00/
Liberating these tests is great and this looks like good work.

Is there anything that we can do with the binary files? In the case of the .ser file then could it be a byte[] in the test with an execution mode that re-generates it? There is also at least one .data file that looks to be the serialized version of a bad ChoiceFormat and maybe that could be moved into the source too.

-Alan

Reply via email to