> On Mar 30, 2016, at 8:40 AM, Masayoshi Okutsu <masayoshi.oku...@oracle.com> > wrote: > > Hello, > > Please review the fix for JDK-8152817. The fix is to load locale data from > its own module without calling > ResourceBundleProviderSupport.loadResourceBundle. > > I changed the synopsis of the JBS issue because it's a general issue of > loading locale data under a security manager, and the regression test uses > DateFormatSymbols. > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8152817 > Webrev: > http://cr.openjdk.java.net/~okutsu/9/8152817/webrev.00/
The patch looks fine. It makes sense to have its own copy of the utility method to load a module-private class. You can call Class::newInstance instead of Constructor::newInstance to make the code much simpler. Class::newInstance doesn’t throw InvocationTargetException and no need to have uncheckedThrow. Mandy
