Hi Martin,
I am not a Calendar expert, but I'd think if a query for narrow names
fails, in some cases it would be useful not to fall back to longer
names, say weekday names in chinese, 星期一..星期五or something like
that. If they were mistakenly displayed at the calendar title row, it
could all display '星' in that narrow field which seems meaningless.
BTW, the fix looks good to me, Masayoshi.
Naoto
On 3/27/15 12:31 PM, Martin Buchholz wrote:
Don't know much about Calendar, but:
do you want below to try fallback twice? Eg. if it's still null after
trying toStandaloneStyle(style), do you want to also try fallback to
getBaseStyle(style) ?
2093 // Perform fallback here to follow the CLDR rules2094
if (val == null) {2095 if
(isNarrowFormatStyle(style)) {2096 val =
CalendarDataUtility.retrieveFieldValueName(calendarType,2097
field,
fieldValue,2098
toStandaloneStyle(style),2099
locale);2100
} else if (isStandaloneStyle(style)) {2101 val =
CalendarDataUtility.retrieveFieldValueName(calendarType,2102
field,
fieldValue,2103
getBaseStyle(style),2104
locale);2105
}2106 }
On Fri, Mar 27, 2015 at 1:48 AM, Masayoshi Okutsu <
masayoshi.oku...@oracle.com> wrote:
Hi,
Please review the fix for 8075548. This change is to follow the fallback
rules of the format-standalone names specified by the alias tag in CLDR.
Bug report:
https://bugs.openjdk.java.net/browse/JDK-8075548
Webrev:
http://cr.openjdk.java.net/~okutsu/9/8075548/webrev.00
Thanks,
Masayoshi
