With the original test case, webrev.1 and webrev.2 both succeed. With
the modified test case (in webrev.2), webrev.1 fails but webrev.2
succeeds. The reason I changed the test case is to catch possible
regression where someone makes changes to the SharedSecret being
initialized at BidiBase class loading time (as in webrev.1).
Naoto
On 7/3/14, 12:35 AM, Alan Bateman wrote:
On 02/07/2014 16:43, Naoto Sato wrote:
So I think the only question
now is the test case and understanding why that needs to be updated.
The test case ensures that even BidiBase class was loaded before
TextAttribte/NumericShaper classes, it should work correctly. Version
1 of this fix (webrev.1) actually fails with this test case.
Naoto
Does it fail with the updated changes in webrev.2? I can't think why the
test would need to be changed with the updated changes.
-Alan
