looks fine. I would assume you've also run the corresponding tests at test/closed repo.
-Sherman On 11/5/2013 8:38 AM, Aleksej Efimov wrote:
Hi, Can I have a review for tzdata2013h integration [1]. The webrev link can be located here [2]. The following test sets were executed on build with fix: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar test/java/util/TimeZone test/java/time test/java/util/Formatter And here is the list of failures: FAILED: java/time/tck/java/time/temporal/TCKWeekFields.java %1% FAILED: java/time/tck/java/time/TCKInstant.java %1% FAILED: java/time/tck/java/time/TCKLocalDate.java %1% FAILED: java/time/tck/java/time/TCKLocalDateTime.java %1% FAILED: java/time/tck/java/time/TCKOffsetDateTime.java %1% FAILED: java/time/tck/java/time/TCKOffsetTime.java %1% FAILED: java/time/tck/java/time/TCKZonedDateTime.java %1% FAILED: java/time/test/java/time/format/TestZoneTextPrinterParser.java %1% FAILED: java/util/Calendar/JavatimeTest.java %1% FAILED: sun/util/calendar/zi/TestZoneInfo310.java The group %1% tests failures relates to the JDK-8027622 bug and are expected (actually, it was already resolved in hotspot repo). The 'TestZoneInfo310' test failure is an actual error in current ZoneInfoFile class implementation in JDK. I have filled a bug for this one [3] and will send a separate review with fix later today. [1] https://bugs.openjdk.java.net/browse/JDK-8027370 [2] http://cr.openjdk.java.net/~aefimov/8027370/webrev.00/ [3] https://bugs.openjdk.java.net/browse/JDK-8027848
