On 06/06/2013 00:18, Masayoshi Okutsu wrote:
When I noticed the warning, actually I tried the exactly same fix (both equals and hashCode). It was supposed to generate the same data after the fix, but the fixed one didn't generate identical data. I haven't had time to look into it further.

Yesterday Yuka looked into the fixed tool and confirmed that the fix didn't affect the runtime. She found the equals part of the fix actually fixed the tool behavior (redundant loop cycles, etc.).

So I think the fix should be pushed.

Masayoshi
I pushed this yesterday (after Yuka's mail and after I tested it on all platforms).

One thing to say that a "diff -r" of $OUTPUTDIR/jdk/classes/sun/text/resources to compare the generated resources between before & after builds doesn't show any differences. I only did this on one platform, not all. So I'm curious about your comment, just in case I'm doing something wrong.

-Alan

Reply via email to