Looks fine; approved.

Thanks,

-Joe

On 9/12/2012 10:19 AM, Olivier Lagneau wrote:
Please review The implementation of a fast-path algorithm for optimizing the DecimalFormat.format(double, ...) call stack.

The webrev is here :
http://cr.openjdk.java.net/~olagneau/7050528/webrev.02/

As described in the CR evaluation and suggested fix, the speed-up on a dedicated micro-benchmark is more than x10 on either SPARC or x86 architectures. The footprint cost is ~6kbytes from a static
char array constant data to collect digits from integer values.

There is an associated regression test, together with a micro-benchmark that may be run optionally.


Reply via email to