Sure I can test if you build it.

On 27. Sep 2023, at 1.01, dudek53 <[email protected]> wrote:

Just want to put out this again but with a refined change.
In ImageTransformsGPU.cpp we have following:

    const int bytesPerDestPixel = 16 + 16 + 8
                                  + ((XGLMap[destGLTransferFormat] != 
GL_RGBA32F_ARB) ? BytesPerPixel[destGLTransferFormat] : 0)
                                  + ((destAlphaBuffer != NULL) ? 1 : 0);
    const long long int maxDestPixels = gpuMemoryRemaining / bytesPerDestPixel;


Change to below for mac M1 ARM 64-bit:
    const int bytesPerDestPixel = 16 + 16 + 8
                                  + ((XGLMap[destGLTransferFormat] != 
GL_RGBA32F_ARB) ? BytesPerPixel[destGLTransferFormat] : 0)
                                  + ((destAlphaBuffer != NULL) ? 1 : 0);
    #ifdef __aarch64__  // Check for ARM 64-bit architecture
    const long long int maxDestPixels = gpuMemoryRemaining / bytesPerDestPixel 
/ 2;
    #else
    const long long int maxDestPixels = gpuMemoryRemaining / bytesPerDestPixel;
    #endif

By reducing bytesPerDestPixel by half I can process huge files on my M1. Tested 
20000 X  13333 pixel files and they come out just fine. My first fix would 
segfault on these files.
Of course this could be tested more and maybe you want a version to try mikko? 
You are actually the first person I hear about selecting the GPU option working 
on M1.

If tested around some maybe it would be a legit fix? What´s your opinion 
T.Modes?

tisdag 26 september 2023 kl. 16:42:51 UTC+2 skrev dudek53:
I see. Yes, the issue is pretty much isolated to some sort of memory chunk 
computation involving gpu but since my personal fix works for me and a few 
friends I did not took the time to try and understand why it works. Anyway. My 
fix is described here so if you manage to compile align_image_stack with that 
fix it should work.

Den tis 26 sep. 2023 16:34Kuutti Mikko (KAVI) <[email protected]> skrev:
The dmg you posted here.

On 26. Sep 2023, at 17.28, dudek53 <[email protected]> wrote:


What build? Is it the beta 1 or a build here.
GPU issue was kind of "fixed" but the fix was not very clean or understandable 
so not shared in public. I plan on dive a little deeper here though and when a 
proper fix is found I'll post it here.

Den tis 26 sep. 2023 15:[email protected] <[email protected]> skrev:

This build seems to work after xattr -c’ing all the apps and as long as you 
don’t check “Use GPU for remapping”. That produces garbage. M1 Max MacBook Pro.
On Saturday, September 23, 2023 at 11:36:31 AM UTC+3 [email protected] wrote:
Fixed! Will delet former message here as it is not possible to edit the message.

On Sat, Sep 23, 2023 at 10:28 AM T. Modes <[email protected]> wrote:
Thanks for building, but …

[email protected] schrieb am Samstag, 23. September 2023 um 10:08:41 UTC+2:
Releasing a mac arm64 build according to this source code relaease from T.Modes:

Please use the dedicated thread for the beta 1 release for such announcement 
and not your "private" mac thread.
So all reports concerning the beta 1 are in one thread and not scattered about 
several ones.
This was explicitly written in the announcement.



--
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/7a6e1cc7-2b96-4f8b-8dc7-472685a3fe98n%40googlegroups.com<https://groups.google.com/d/msgid/hugin-ptx/7a6e1cc7-2b96-4f8b-8dc7-472685a3fe98n%40googlegroups.com?utm_medium=email&utm_source=footer>.

--
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/e89e2bbc-0e5c-47a4-9a97-31db4e9ced81n%40googlegroups.com<https://groups.google.com/d/msgid/hugin-ptx/e89e2bbc-0e5c-47a4-9a97-31db4e9ced81n%40googlegroups.com?utm_medium=email&utm_source=footer>.

--
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to a topic in the Google 
Groups "hugin and other free panoramic software" group.
To unsubscribe from this topic, visit 
https://groups.google.com/d/topic/hugin-ptx/cAzcl7HaQs4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to 
[email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/CAHk3tqgVdG2dWO0M3B9ip%2BTHp%3DPf0z40O%3DvRDqW9rzcyWu8czw%40mail.gmail.com<https://groups.google.com/d/msgid/hugin-ptx/CAHk3tqgVdG2dWO0M3B9ip%2BTHp%3DPf0z40O%3DvRDqW9rzcyWu8czw%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/E654A214-994B-46C4-8C43-BDE9A66D2084%40kavi.fi<https://groups.google.com/d/msgid/hugin-ptx/E654A214-994B-46C4-8C43-BDE9A66D2084%40kavi.fi?utm_medium=email&utm_source=footer>.

--
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to a topic in the Google 
Groups "hugin and other free panoramic software" group.
To unsubscribe from this topic, visit 
https://groups.google.com/d/topic/hugin-ptx/cAzcl7HaQs4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to 
[email protected]<mailto:[email protected]>.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/75f22350-875b-48dc-9341-92427f25a9e1n%40googlegroups.com<https://groups.google.com/d/msgid/hugin-ptx/75f22350-875b-48dc-9341-92427f25a9e1n%40googlegroups.com?utm_medium=email&utm_source=footer>.

-- 
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
--- 
You received this message because you are subscribed to the Google Groups 
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/hugin-ptx/FED2B6E5-DA57-4E65-B40A-2CB7B7E90707%40kavi.fi.

Reply via email to