On 2023-07-22 Bruno Postle <[email protected]> wrote: > On Sat, 22 Jul 2023, 13:36 Andreas Metzler, wrote: >> On 2023-07-18 Bruno Postle wrote: >>> libpano13 is the PanoTools library for panoramic imaging.
>>> A libpano13-2.9.22 rc1 tarball has been uploaded to sourceforge, this is >>> a release candidate for testing that may become the final release: >> This breaks the ABI: >> a) Removed ShowScript and LaunchAndSendScript function >> b) >> -PANO13_IMPEX int WriteScript ( char* res, >> fullPath* scriptFile, int launch ); >> +PANO13_IMPEX int WriteScript ( char* res, >> fullPath* scriptFile ); [...] > Thanks, and I am a little ignorant about these details: since no known > tools actually use these functions, will leaving the soname unchanged be a > problem for tools that use other parts of the library eg. Hugin, nona > etc..? My testing seems to be ok. Hello Bruno, Yes, if they do not use either the removed or the changed functions they should continue to work. > We could bump the soname, or we could replace these functions with no-op > stubs to quieten the abi checkers. What do you think? I am not in favour of that, you'd still break the functional (but unused, yeah) interface. Also WriteScript/WriteResults changes would need to be reverted to keep the ABI unchanged. Imho there is a simple way to do this cleanly and no need to try to be clever about it. cu Andreas -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure' -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/ZLwIHDLpxm4lY6Gw%40argenau.bebt.de.
