It is difficult to comment because you are often mixing things. Or as an example you contradict yourself
[email protected] schrieb am Dienstag, 1. Februar 2022 um 15:41:14 UTC+1: > Hiding would only be temporary: other actions make the magnifier appear > and "hiding" would not suppress that. and later > I want the new 'm' key operation to be the only thing that hides the > magnifier. > > > I would entirely remove the timer. It's only purpose is to hide the > magnifier. I see no logic to when that timer is used vs. not used. Maybe > the original intent was to always have that timer (never let the magnifier > stay in view for over 2 seconds). As a user I see* zero* value in timer > based hiding of the magnifier. But if others strongly disagree, (with > significantly more work) I could invent a setting to allow that feature to > be disabled (rather than take the feature away from everyone). > I disagree: I like the feature that the magnifier disappear so I have a better view on the whole neighbourhood of the cp. This makes it easier for me the judge the cp. > With my limited understanding of mercurial, I was able to see the timer > feature was added by ippei in commit 91503d5bebff > No. This was a major overhaul of the structure. The timer was added in changeset 689b688f70f5. > I also want to remove all other existing logic for hiding the magnifier, > such as hiding it when the image itself is zoomed 200%. > The disabling of the magnifier for the 200 % view was added as a feature request. So there are uses which prefer this. > I would tend to want to pretest and commit all those and related features > all together. But I have been warned that doing so would make things too > hard for whoever reviews/merges my changes. > Please, one change - one changeset. Do not mix things in one changeset. You can also send patches (diff files) for other people for testing. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/caf367c9-547b-4020-a447-98ff65c14069n%40googlegroups.com.
