Errata:
Line 96 of threadpool.cpp should read (as above):
for (i = 0; i < *n_threads*; ++i) {
Line 641 of pyramid.cpp should read:
if (x_shift) memmove(*&((float*)line)[1]*, line, (m128_pitch_hi << 4) -
*4*);
(the first bit is just for clarity, the 1, now a 4, at the end was a bug)
Line 424 of functions.cpp should read:
for (i = 0; i < 5; ++i) delete*[]* real_lines[i];
Line 90 of functions.cpp should read:
delete*[]* rows;
This just leaves a bunch of indirect leaks which I should probably clean up
one day just to be nice about it but don't have any effect on execution.
On Saturday, 3 April 2021 at 13:59:33 UTC+1 Monkey wrote:
> Oh, how embarrassing... for a fix to that immediate problem, change line
> 96 of threadpool.cpp to read:
>
> for (i = 0; i < *n_threads*; ++i) {
>
> -fsantize=address - which I shall try to remember to use in future! - is
> still reporting some other problems so I'll fix those before I update the
> source download.
> On Friday, 2 April 2021 at 08:58:12 UTC+1 [email protected] wrote:
>
>> I do very much appreciate this effort!
>> Unfortunate the new one fails to stitch a 1.2gigapixel image that the old
>> one stitched perfectly, so I compiled it with -fsanitize=address and got
>> very early this one :
>>
>> ==8137==ERROR: AddressSanitizer: heap-buffer-overflow on address
>> 0x6110000003b0 at pc 0x55be84604975 bp 0x7ffd3aef4e90 sp 0x7ffd3aef4e80
>> READ of size 1 at 0x6110000003b0 thread T0
>>
>>
>> #0 0x55be84604974 in Threadpool::Wait()
>> (/usr/src/multiblend2/src/multiblend+0x39974)
>> #1 0x55be846147ed in Image::Read(void*, bool)
>> (/usr/src/multiblend2/src/multiblend+0x497ed)
>>
>>
>> Il giorno domenica 7 marzo 2021 alle 14:00:01 UTC+1 Sergio Amateis ha
>> scritto:
>>
>>> Hi David, thank you for your help. I will try another stitch removing
>>> the sky's photos and generating a partial panorma. For the sky, Hugin
>>> can't obvioulsy find any control point. So I have entered some points very
>>> roughly, just to keep the photos of the sky in the right place. Is there
>>> another way to position them better, perhaps manually without using control
>>> points?
>>>
>>> Il giorno domenica 7 marzo 2021 alle 00:14:00 UTC+1 Monkey ha scritto:
>>>
>>>> Sorry, I didn't get around to looking into your project too much.
>>>> Neither Enblend nor Multiblend can do much about such misalignments, as
>>>> they come from Hugin's processing of control points, and you have some
>>>> problematic control points in your project. If you open the Control Point
>>>> table and sort by distance (highest first) you'll see a lot of control
>>>> points in sky (click on each one to see them in the Control Point editor)
>>>> with very high distances, which you should delete - they are either in
>>>> blue
>>>> sky, which can't make a good alignment and will drag the rest of the
>>>> pictures out of alignment, or they are on clouds which move between shots.
>>>> After deleting those and re-optimising, you should get a better final
>>>> result - altough you could use more control points on the building, rather
>>>> than (for example) on the tree behind it (right corner).
>>>>
>>>> David
>>>>
>>>> On Saturday, 6 March 2021 at 22:50:33 UTC [email protected] wrote:
>>>>
>>>>> Hi Monkey,
>>>>> I have done some tests with the same 56 photos 360° Panorama I already
>>>>> sent to you. I have a pto with some masks to avoid bad seams on the
>>>>> buildings.
>>>>> Stitching this with Multiblend is much much faster but the result is
>>>>> not better than the enblend one. There are stitching errors in the same
>>>>> zones as enblend did, just displaced a little bit. Then I tried to remove
>>>>> all masks and again stitch with enblend and multiblend. This time
>>>>> multiblend shows a few more errors than enblend, but again, results are
>>>>> similar.
>>>>>
>>>>> Aside from speed, should I find other advantages in multiblend? Is
>>>>> there any parameter I can try, to improve the stiching precision ?
>>>>>
>>>>> Thank you
>>>>> Ginosergio
>>>>>
>>>>>
>>>>> Il giorno sabato 6 marzo 2021 alle 17:50:43 UTC+1 Monkey ha scritto:
>>>>>
>>>>>> I uploaded both .exes to VirusTotal. 11/69 reported the x86 version
>>>>>> as suspect, and 1/69 reported the x64 version as suspect.
>>>>>>
>>>>>> I think this is just a hazard of the ubiquity of viruses. You can
>>>>>> probably find something that vaguely resembles some virus in any piece
>>>>>> of
>>>>>> code. There's nothing particularly clever or unusual in Multiblend's
>>>>>> code -
>>>>>> no self-modifying code and no built-in compiler, one of which I have
>>>>>> previously written and which caused a lot of false positives. It could
>>>>>> be
>>>>>> something as simple as its use of threads of memory-mapped files that
>>>>>> raises suspicions.
>>>>>>
>>>>>> As for the site itself, it might be blocked just because it doesn't
>>>>>> have HTTPS (my current host is pretty terrible and their Let's Encrypt
>>>>>> option doesn't work).
>>>>>>
>>>>>> On Saturday, 6 March 2021 at 15:44:27 UTC [email protected] wrote:
>>>>>>
>>>>>>> Hi Monkey
>>>>>>>
>>>>>>> I am only writing to report that my BITDEFENDER TOTAL SECURITY:
>>>>>>> - reports the site http://horman.net/multiblend/ as dangerous,
>>>>>>> and blocks it.
>>>>>>> - in the zip with windows binaries, it reports multiblend_x86.exe as
>>>>>>> a virus, and deletes it. (not a great problem as I think everyone is
>>>>>>> now on
>>>>>>> 64bit)
>>>>>>> I'm starting to think I'll throw Bitdefender away when my
>>>>>>> subscription expires.
>>>>>>>
>>>>>>> I will report again after some tests with my big 360 panoramas.
>>>>>>>
>>>>>>> Cheers
>>>>>>> Ginosergio
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Il giorno sabato 6 marzo 2021 alle 13:42:13 UTC+1 Monkey ha scritto:
>>>>>>>
>>>>>>>> Thanks Harry.
>>>>>>>>
>>>>>>>> On Saturday, 6 March 2021 at 12:24:17 UTC [email protected] wrote:
>>>>>>>>
>>>>>>>>> And a distributable macos build for multiblend *2.0rc2*:
>>>>>>>>> https://mega.nz/file/lQtlgKRI#wNYpcmE4-XuZJOsXmxtBkBmB6Ekji-Vp65c38FCaGws
>>>>>>>>> Unzip to a folder of your liking with paths. It should give:
>>>>>>>>> multiblend-dist/
>>>>>>>>> multiblend-dist/Libraries/
>>>>>>>>> multiblend-dist/Libraries/libz.1.2.11.dylib
>>>>>>>>> multiblend-dist/Libraries/libpng16.16.dylib
>>>>>>>>> multiblend-dist/Libraries/libzstd.1.4.8.dylib
>>>>>>>>> multiblend-dist/Libraries/libtiff.5.dylib
>>>>>>>>> multiblend-dist/Libraries/liblzma.5.dylib
>>>>>>>>> multiblend-dist/Libraries/libjpeg.8.2.2.dylib
>>>>>>>>> multiblend-dist/multiblend
>>>>>>>>>
>>>>>>>>> Removed a few "sloppy" things from the script:
>>>>>>>>> https://mega.nz/file/FR9CxCpB#ucZGem59Z6n8jVP7NriuqKS9YwGvMtIok9DZqX75vro
>>>>>>>>>
>>>>>>>>> Harry
>>>>>>>>>
>>>>>>>>> Op za 6 mrt. 2021 om 13:02 schreef Monkey <[email protected]>:
>>>>>>>>>
>>>>>>>>>> Fixed and updated, plus a fix to ignore (properly) an Enblend
>>>>>>>>>> parameter that was stopping Hugin from successfully calling
>>>>>>>>>> Multiblend.
>>>>>>>>>>
>>>>>>>>>> http://horman.net/multiblend/
>>>>>>>>>>
>>>>>>>>>> David
>>>>>>>>>> On Saturday, 6 March 2021 at 11:22:47 UTC [email protected] wrote:
>>>>>>>>>>
>>>>>>>>>>> Builds fine and runs fine (under Hugin) on my Ubuntu derived
>>>>>>>>>>> box. GalliumOS 3.1 (Ubuntu 18.04 LTS)
>>>>>>>>>>> (Linux edgar 4.16.18-galliumos #1 SMP PREEMPT Sun Jun 23
>>>>>>>>>>> 04:14:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux)
>>>>>>>>>>>
>>>>>>>>>>> On MacOS Catalina I had to replace in multiblend.cpp the
>>>>>>>>>>> following:
>>>>>>>>>>> #include <algorithm>
>>>>>>>>>>> #include <malloc.h>
>>>>>>>>>>>
>>>>>>>>>>> #include "tiffio.h"
>>>>>>>>>>> #include "jpeglib.h"
>>>>>>>>>>>
>>>>>>>>>>> with:
>>>>>>>>>>> #include <algorithm>
>>>>>>>>>>> #ifdef __APPLE__
>>>>>>>>>>> #define memalign(a,b) malloc((b))
>>>>>>>>>>> #else
>>>>>>>>>>> #include <malloc.h>
>>>>>>>>>>> #endif
>>>>>>>>>>>
>>>>>>>>>>> #include "tiffio.h"
>>>>>>>>>>> #include "jpeglib.h"
>>>>>>>>>>>
>>>>>>>>>>> Please correct that before final 2.0 release.
>>>>>>>>>>> With that it builds fine on MacOS and runs fine under Hugin. I
>>>>>>>>>>> now used Macports instead of homebrew, as I needed macports for pv.
>>>>>>>>>>> See attached your modified build.txt.
>>>>>>>>>>> I also created a distributable version:
>>>>>>>>>>> https://mega.nz/file/VEkRlKLY#zt2oymaxcqi1gK-XrKzE0fGiPs8W3lYzXL2yuC89DFM
>>>>>>>>>>> Unzip the zip with paths (!) to some location of your liking. It
>>>>>>>>>>> will create a folder multiblend-dist and inside you will find
>>>>>>>>>>> multiblend
>>>>>>>>>>> and it's 3rd party necessary libraries.
>>>>>>>>>>> In Hugin preferences under programs select "use other enblend
>>>>>>>>>>> program" and give the full path to multiblend.
>>>>>>>>>>>
>>>>>>>>>>> Script to create a distributable multiblend (using macports):
>>>>>>>>>>> https://mega.nz/file/sc8hXIrT#6SYq8Dbei8KZZxocDQ9iSidv__qDJjc7RMaNCwTRFIo
>>>>>>>>>>> Create a "mac-dist" subfolder in your build directory and use
>>>>>>>>>>> the script from there. Read the info in the script before use.
>>>>>>>>>>> Of course this script already expects a compiled multiblend in
>>>>>>>>>>> the build folder.
>>>>>>>>>>>
>>>>>>>>>>> Hoi,
>>>>>>>>>>> Harry
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>> A list of frequently asked questions is available at:
>>>>>>>>>> http://wiki.panotools.org/Hugin_FAQ
>>>>>>>>>> ---
>>>>>>>>>> You received this message because you are subscribed to the
>>>>>>>>>> Google Groups "hugin and other free panoramic software" group.
>>>>>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>>>>>> send an email to [email protected].
>>>>>>>>>> To view this discussion on the web visit
>>>>>>>>>> https://groups.google.com/d/msgid/hugin-ptx/2ea613a7-9e0f-4605-961a-63cf504d461dn%40googlegroups.com
>>>>>>>>>>
>>>>>>>>>> <https://groups.google.com/d/msgid/hugin-ptx/2ea613a7-9e0f-4605-961a-63cf504d461dn%40googlegroups.com?utm_medium=email&utm_source=footer>
>>>>>>>>>> .
>>>>>>>>>>
>>>>>>>>>
--
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
---
You received this message because you are subscribed to the Google Groups
"hugin and other free panoramic software" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/hugin-ptx/c4ffa1ab-d920-4c58-bff4-0674ffdfd9c6n%40googlegroups.com.
