Hello everybody, I just noticed the Twitter ruleset example at https://www.eff.org/https-everywhere/rulesets is using a capturing group, (www\.), but doesn't use result matched by the group.
It should be changed to a non-capturing group (which has better performance) so people writing a ruleset won't make the same mistake. Current ruleset <ruleset name="Twitter"> <target host="www.twitter.com" /> <target host="twitter.com" /> <rule from="^http://(www\.)?twitter\.com/" to="https://twitter.com/"/> </ruleset> Fixed <ruleset name="Twitter"> <target host="www.twitter.com" /> <target host="twitter.com" /> <rule from="^http://(*?:*www\.)?twitter\.com/" to="https://twitter.com/"/> </ruleset> (Non-capturing groups start with *?:*.) Regards, Johan
