| Oh wait, tests are not passing anymore. Something went wrong... Ok, so I fixed the test t/i18n/add_localize_object.t so it holds a strong reference of the localize_object outside of FormFu. To fix the test t/i18n/add_localize_object_from_class.t I need some wisdom of the community. I guess when using add_localize_object_from_class, localize_object will have no other reference than within localize_data, so weaken it will destroy it. So I added a key within $self to indicate whether to weaken the localize_object or not. Basically how the weaken_localize_object key is added and retrieved seems a bad way to me, but I think I cannot add another parameter to add_localize_object() because it is used by other modules and would break them. Any thoughts about this? Please find a new patch attached to this mail or view the commit a github: https://github.com/rainboxx/HTML-FormFu/commit/087450dfc463632a22771dc30facb75007036f7d Thanks, Matthias -- rainboxx Software Engineering Matthias Dietrich rainboxx Matthias Dietrich | Phone: +49 7141 / 2 39 14 71 Königsallee 43 | Fax : +49 3222 / 1 47 63 00 71638 Ludwigsburg | Mobil: +49 151 / 50 60 78 64 | WWW : http://www.rainboxx.de CPAN: http://search.cpan.org/~mdietrich/ XING: https://www.xing.com/profile/Matthias_Dietrich18 GULP: http://www.gulp.de/profil/rainboxx.html |
leak_fix.patch
Description: Binary data
_______________________________________________ HTML-FormFu mailing list HTML-FormFu@lists.scsys.co.uk http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/html-formfu
