> probably. Or make you doubt, so to make you read it all.. The trick is to put it at the end :)
(TLDR; = Too Long, Didn't Read;) On Wed, Mar 23, 2016 at 7:12 PM, Sanne Grinovero <sa...@hibernate.org> wrote: > On 23 March 2016 at 19:07, Davide D'Alto <daltodav...@gmail.com> wrote: > > Yeah, go with it. > > I don't think it is going to be too hard to fix the conflicts in the > Neo4j > > module. > > Ok, thanks: > - https://hibernate.atlassian.net/browse/OGM-1001 > > > > >>TLRD: > > > > Did you mean: TLDR; > > probably. Or make you doubt, so to make you read it all.. > > Sanne > > > > > > > > On Wed, Mar 23, 2016 at 7:02 PM, Gunnar Morling <gun...@hibernate.org> > > wrote: > >> > >> +1 for fixing these things, I also was wondering about some apparent > style > >> violations which CS failed to report. Must have been these bug fixes > then. > >> > >> The only thing coming to my mind is Davide's work which may change > things > >> in the existing Neo4j code. Maybe you two quickly sync? Apart from that > >> I'd > >> say let's do it. > >> > >> 2016-03-23 19:57 GMT+01:00 Sanne Grinovero <sa...@hibernate.org>: > >> > >> > TLRD: don't be surprised if I'll be sending some rather large code > >> > style fixes. Not wasting my time nor intending to waste yours.. > >> > > >> > > >> > I've been writing quite some code enjoying Java 8 specific features in > >> > the new OGM module, > >> > as I assumed this would not be an issue at all since Hot Rod requires > >> > Java8 and we require Java8 to build anyway. > >> > > >> > Unfortunately the Checkstyle plugin crashes when it encounters Java8 > >> > bytecode ops, something which is easily fixed with a plugin upgrade. > >> > The plugin upgrade however *fixed* some bugs in Checkstyle, for which > >> > it had been accepting some syntax even though we were explicitly > >> > intending to guard against these. > >> > > >> > So now there are several (~300) style failures; these are legitimate > >> > failures so my plan is to fix these. > >> > > >> > If someone is busy with some rather large refactoring, please speak up > >> > now as I can wait with this, or we can stagger this cleanup by sending > >> > the fixes for some modules only, and the remaining later. > >> > > >> > P.S. I'd rather cleanup the bad code than revert my Java8 code.. both > >> > as a lesser effort, and as a better ultimate result. > >> > > >> > Thanks, > >> > Sanne > >> > _______________________________________________ > >> > hibernate-dev mailing list > >> > hibernate-dev@lists.jboss.org > >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev > >> > > >> _______________________________________________ > >> hibernate-dev mailing list > >> hibernate-dev@lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
