I made the change for 4.2. For 5.0, we should switch to the current 5.1 documentation because the 5.0 User Guide lacks a lot of information. It requires adding the asciidoc documentation, Gradle configs, and also change the release procedure to use asciidoc instead of docbook.
Should we add a new task for this? Vlad On Tue, Mar 22, 2016 at 8:07 PM, Gail Badner <gbad...@redhat.com> wrote: > Hi Vlad, > > Yes, please update the doc for 5.0 and 4.2. > > Thanks! > Gail > > On Sun, Mar 20, 2016 at 11:37 PM, Vlad Mihalcea <mihalcea.v...@gmail.com> > wrote: > >> Hi Gail, >> >> For the 5.0 branch, I could update the doc for this issue. A new release >> will publish the updated doc, right? >> Should the documentation be updated for the 4.x branches too? >> >> Vlad >> >> On Thu, Mar 17, 2016 at 9:04 PM, Steve Ebersole <st...@hibernate.org> >> wrote: >> >>> It looks like it changed during 3.6 -> 4.0, reverting back to ON_CLOSE. >>> I agree it should changed to AFTER_TRANSACTION, however I would only >>> change it on master. >>> >>> For the other branches, if anything, just update the doc. >>> >>> >>> On Thu, Mar 3, 2016 at 12:40 AM Vlad Mihalcea <mihalcea.v...@gmail.com> >>> wrote: >>> >>>> I think this PR is valid: >>>> >>>> https://github.com/hibernate/hibernate-orm/pull/997 >>>> >>>> I checked it out and, when using JDBC, we use the ON_CLOSE connection >>>> release mode. >>>> >>>> Shouldn't we use the AFTER_TRANSACTION release mode as we state in the >>>> docs? >>>> >>>> Vlad >>>> _______________________________________________ >>>> hibernate-dev mailing list >>>> hibernate-dev@lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>> >>> >> > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
