Hi, On Sat, Mar 21, 2015 at 10:55:58AM -0500, Steve Ebersole wrote: > For me its a matter of consistency. Put simply a Service comes from a > ServiceRegistry. That's consistent. This idea that some particular > Service might come from here or there or this other place is not > consistent. To me.
+1 This is the exactly the point I tried to make earlier as well. > > We don't have a strategy to pick one implementation if there are > > multiple implementations around (other than throwing an exception), so > > having a service defined in the engine jar, essentially means noone > > can plug an alternative, unless he overrides the > > SearchConfiguration#getProvidedServices() method. If we have a need for a selection strategy we should investigate how this can be solved. We explicitly deferred it at the time, since we thought it was not needed for now. > > So if the intention was to allow choice, something is missing +1 >> If not, I'd rather load the default implementations explicitly (via their > > traditional constructor). Where and how would you do that? --Hardy
pgpW22VnfaqcH.pgp
Description: PGP signature
_______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev