On 11/19/2014 11:26 AM, Steve Ebersole wrote: > ORM has had local resolution of these DTDs forever. Something is amiss > in your set up. I just ran ORM tests and the DTDs are being resolved > locally properly.
Thanks for checking. > > Can you make sure control is getting through our registered > EntityResolver? Ultimately, this should be resolved > by org.hibernate.internal.util.xml.DTDEntityResolver I'll give this a try. > > On Wed, Nov 19, 2014 at 10:04 AM, Gunnar Morling <gun...@hibernate.org > <mailto:gun...@hibernate.org>> wrote: > > 2014-11-19 16:48 GMT+01:00 Scott Marlow <smar...@redhat.com > <mailto:smar...@redhat.com>>: > > > On 11/19/2014 08:53 AM, Sanne Grinovero wrote: > > > On 19 November 2014 01:13, Scott Marlow <smar...@redhat.com > <mailto:smar...@redhat.com>> wrote: > > >> Related question, should we instead be using the > > >> org/hibernate/hibernate-configuration-3.0.dtd in > > >> hibernate-core-4.3.7.Final.jar (instead of accessing > thehibernate.org <http://hibernate.org> > > >> website)? > > > > > > I'd agree that it's generally not a good idea to rely on external web > > > services in your tests. Although in this case it's turned out useful > > > as we got your notification about the problem :) > > > > I'm not exactly sure what I need to change in the tests to use the local > > org/hibernate/hibernate-configuration-3.0.dtd (ORM jar) copy of the DTD. > > I tried a few different options but the only thing that helped was > > removing the DTD reference. > > > > For example, what should > > > > >https://github.com/wildfly/wildfly/blob/master/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/jpa/cfgfile/CfgFileTestCase.java#L54 > > be changed to? > > > > I tried changing the "PUBLIC" to "SYSTEM" but that didn't seem to make a > > difference (also tried adding a classpath reference which some forum > > posts talked about doing). > > > > I don't think that's something which can (or should) be controlled > within > the test. > > Rather the code processing the XML file in ORM should make sure to > use the > local version of the DTD. That's how it's done in Validator: > > > > https://github.com/hibernate/hibernate-validator/blob/master/engine/src/main/java/org/hibernate/validator/internal/xml/ValidationXmlParser.java > > Not sure how helpful it is though, as this is for XSDs and we're > using JAXB > to do the parsing, so it may be a bit different to do in ORM. > > --Gunnar > > > > > > > > Sanne > > > > > >> > > >> On 11/18/2014 07:48 PM, Scott Marlow wrote: > > >>> Trying to open > > http://hibernate.org/dtd/hibernate-configuration-3.0.dtd, > > >>> gives a: > > >>> > > >>> " > > >>> Site temporarily disabled > > >>> > > >>> This page has been temporarily disabled due to a > misconfigured custom > > >>> domain. > > >>> > > >>> Are you the site owner? Follow the instructions for setting > up a custom > > >>> domain with GitHub pages to update your site's DNS records to > point to > > >>> the proper IP address. > > >>> > > >>> You can find more information in our GitHub Pages legacy IP > deprecation > > >>> blog post. If you have any questions, please contact support. > > >>> " > > >>> > > >>> The above causes a WildFly test failure > http://pastebin.com/fm8VMCcb > > >>> (from org.hibernate.service.internal.JaxbProcessor.unmarshal). > > >>> > > >>> Scott > > >>> _______________________________________________ > > >>> hibernate-dev mailing list > > >>> hibernate-dev@lists.jboss.org > <mailto:hibernate-dev@lists.jboss.org> > > >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > >>> > > >> > > >> _______________________________________________ > > >> hibernate-dev mailing list > > >> hibernate-dev@lists.jboss.org > <mailto:hibernate-dev@lists.jboss.org> > > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > _______________________________________________ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org <mailto:hibernate-dev@lists.jboss.org> > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org <mailto:hibernate-dev@lists.jboss.org> > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
