On 06/06/2013 11:31 AM, Scott Marlow wrote: > One change that I submitted a WildFly 8 pull request for > (https://github.com/wildfly/wildfly/pull/4591), is to combine the > Hibernate ORM/envers and JipiJapa integration jars into the same module. > This eliminates the 1-1 bi-directional dependency between ORM/JipiJapa > integration code that existed in AS 7 and makes it easier for > application deployments to include the Hibernate ORM jars and JipiJapa > integration code. > > I'm keeping static no-op modules around for the JipiJapa integration > code that I moved into the Hibernate ORM module, in case applications > have dependencies on the older static module (org.jboss.as.jpa.hibernate:4). > > If the static Hibernate Search module, depends on a static Hibernate ORM > module in WildFly 8, I think that is fine, but applications wouldn't be > able to include their own Hibernate Search jars (since the static > Hibernate ORM module only sees services in the static Hibernate Search > module).
My bad. Sanne and I talked yesterday and he reminded me that Hibernate ORM integrators can load (Hibernate Search) services from the application classpath. > > For WildFly 8, do we want to allow applications to bundle its own > version of Hibernate Search that could work with bundled Hibernate ORM jars? In my testing of deploying an application that uses a clustered second level cache, I hit a NPE in Infinispan, since it didn't know about the hibenate-infinispan configuration (Infnispan service loading didn't occur for the application embedded Hibernate ORM jar). Oh the shame for getting these two cases (Search + 2lc) mixed up :( > > Scott > > On 06/06/2013 07:37 AM, Emmanuel Bernard wrote: >> Below is an email describing the issues i had to get Hibernate Search run in >> WildFly / EAP. A possibility to make life easier for Hibernate Search users >> in WildFly is as described by Pete to create a hibernate-search-orm-wildfly >> which marks Hibernate ORM as provided. >> >> What do you think? >> >> Emmanuel >> >> Begin forwarded message: >> >>> From: Pete Muir <pm...@redhat.com> >>> Date: 6 juin 2013 11:21:13 UTC+02:00 >>> To: Emmanuel Bernard <emman...@hibernate.org> >>> Cc: jdf-...@lists.jboss.org >>> Subject: Re: [jdf-dev] JBoss Modules dependency vs pain POM dependency + >>> exclusions >>> >>> Hey Emmanuel, >>> >>> On 5 Jun 2013, at 19:25, Emmanuel Bernard <emman...@hibernate.org> wrote: >>> >>>> The Hibernate Search enabled version of TicketMonster relies on >>>> Hibernate Search 4.3 which itself has a dependency on Hibernate ORM >>>> included in WildFly and JBoss EAP. >>>> >>>> My first approach was to ask the user to add the Hibernate Search JBoss >>>> Module manually into their EAP / WildFly distribution and have it >>>> referenced in jboss-deployment-structure.xml. >>>> I also had to put Hibernate Search in my POM as provided because the BOM >>>> references an older version of Hibernate Search. >>> >>> We should be targeting the version of HSearch that is in WFK. If the BOM is >>> out of date (highly possible), then please either send a pull to update it >>> or ask Rafael to do so. He or I can do a you a release very quickly once >>> the change is in. >>> >>>> >>>> To avoid the manual step, I tried to list Hibernate Search explicitly in >>>> the POM as regular scope and no longer use >>>> jboss-deployment-structure.xml. But then I have to play with exclusions >>>> which is not too nice either. >>>> >>>> Which approach is better suited for TicketMonster? And is there a better >>>> way? >>> >>> Fix the HSearch POM so that it marks as optional or provided stuff that you >>> are excluding would be one way. If you don't want to do this, then another >>> option would be to produce a HSearch-for-WF pom as part of HSearch that >>> does it. >>> >>> In general, it's better to not make the user fiddle with exclusions, and >>> instead do it in the framework itself. >>> >>>> >>>> Here is the commit that moves from a module dependency to plain pom.xml >>>> https://github.com/emmanuelbernard/ticket-monster/commit/9da10a15921367d074783711a5692297e02318b6 >>>> >>>> Emmanuel >>>> _______________________________________________ >>>> jdf-dev mailing list >>>> jdf-...@lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/jdf-dev >>> >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
