In terms of exception handling, of course you are right in terms of
final product.
IIUC that not how use of jboss-logging for generating exception messages
is supposed to work, though to be honest, I do not know the details.
Since you "use this in Validator and Search" I would figure you would
know how to do it.
The "purpose of the annotation processor" is couple-fold, but here the
intention is to handle i18n of the logged messages, same as it would for
exception messages that you want...
On 08/31/2012 05:23 AM, Hardy Ferentschik wrote:
> Hi,
>
> I just bumped into a couple of issues when working on some metamodel tests.
>
> First thing I came across was a NullPointerException :-( Turns out I was
> missing to add a annotated class to the test.
> Digging a little deeper I noticed that the problem is in the Binder. It does
> something like:
>
> final EntitySource entitySource =
> entitySourcesByName.get( entityName );
> final EntityBinding superEntityBinding =
> SubclassEntitySource.class.isInstance(
> entitySource )
> ? entityBinding( ( (
> SubclassEntitySource ) entitySource
> ).superclassEntitySource().getEntityName() )
> : null;
>
> If the user for some reason forgets to add all configuration sources he will
> just get a NullPointerException. Not nice :-(
> It seems this is a general problem in the Binder atm. We have to better cater
> for border cases and think about
> potential problems and how we can provide useful feedback.
>
> Next, I tried to change this to
>
> final EntitySource entitySource =
> entitySourcesByName.get( entityName );
> if(entitySource == null) {
> throw coreLogger.missingEntitySourceException(
> entityName );
> }
>
> // Get super entity binding (creating it if necessary
> using recursive call to this method)
> final EntityBinding superEntityBinding =
> SubclassEntitySource.class.isInstance(
> entitySource )
> ? entityBinding( ( (
> SubclassEntitySource ) entitySource
> ).superclassEntitySource().getEntityName() )
> : null;
>
> where I added the following to CoreMessageLogger:
>
> @Message(value = "Unable to find mapping information for %s. Are you sure all
> annotated classes and configuration files are added?", id = 443)
> /MappingException missingEntitySourceException(String entityName);
>
> I just want to get a i18n exception. When doing so, the generation of the
> logger classes fails!
>
> org.gradle.api.tasks.TaskExecutionException: Execution failed for task
> ':hibernate-core:generateMainLoggingClasses'.
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:68)
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:46)
> at
> org.gradle.api.internal.tasks.execution.PostExecutionAnalysisTaskExecuter.execute(PostExecutionAnalysisTaskExecuter.java:34)
> at
> org.gradle.api.internal.changedetection.CacheLockHandlingTaskExecuter$1.run(CacheLockHandlingTaskExecuter.java:34)
> at
> org.gradle.cache.internal.DefaultCacheAccess$2.create(DefaultCacheAccess.java:200)
> at
> org.gradle.cache.internal.DefaultCacheAccess.longRunningOperation(DefaultCacheAccess.java:172)
> at
> org.gradle.cache.internal.DefaultCacheAccess.longRunningOperation(DefaultCacheAccess.java:198)
> at
> org.gradle.cache.internal.DefaultPersistentDirectoryStore.longRunningOperation(DefaultPersistentDirectoryStore.java:137)
> at
> org.gradle.api.internal.changedetection.DefaultTaskArtifactStateCacheAccess.longRunningOperation(DefaultTaskArtifactStateCacheAccess.java:83)
> at
> org.gradle.api.internal.changedetection.CacheLockHandlingTaskExecuter.execute(CacheLockHandlingTaskExecuter.java:32)
> at
> org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:55)
> at
> org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:57)
> at
> org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:41)
> at
> org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)
> at
> org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:52)
> at
> org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:42)
> at
> org.gradle.api.internal.AbstractTask.executeWithoutThrowingTaskFailure(AbstractTask.java:247)
> at
> org.gradle.execution.DefaultTaskGraphExecuter.executeTask(DefaultTaskGraphExecuter.java:192)
> at
> org.gradle.execution.DefaultTaskGraphExecuter.doExecute(DefaultTaskGraphExecuter.java:177)
> at
> org.gradle.execution.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:83)
> at
> org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:36)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:61)
> at
> org.gradle.execution.DefaultBuildExecuter.access$200(DefaultBuildExecuter.java:23)
> at
> org.gradle.execution.DefaultBuildExecuter$2.proceed(DefaultBuildExecuter.java:67)
> at
> org.gradle.api.internal.changedetection.TaskCacheLockHandlingBuildExecuter$1.run(TaskCacheLockHandlingBuildExecuter.java:31)
> at
> org.gradle.cache.internal.DefaultCacheAccess$1.create(DefaultCacheAccess.java:111)
> at
> org.gradle.cache.internal.DefaultCacheAccess.useCache(DefaultCacheAccess.java:126)
> at
> org.gradle.cache.internal.DefaultCacheAccess.useCache(DefaultCacheAccess.java:109)
> at
> org.gradle.cache.internal.DefaultPersistentDirectoryStore.useCache(DefaultPersistentDirectoryStore.java:129)
> at
> org.gradle.api.internal.changedetection.DefaultTaskArtifactStateCacheAccess.useCache(DefaultTaskArtifactStateCacheAccess.java:79)
> at
> org.gradle.api.internal.changedetection.TaskCacheLockHandlingBuildExecuter.execute(TaskCacheLockHandlingBuildExecuter.java:29)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:61)
> at
> org.gradle.execution.DefaultBuildExecuter.access$200(DefaultBuildExecuter.java:23)
> at
> org.gradle.execution.DefaultBuildExecuter$2.proceed(DefaultBuildExecuter.java:67)
> at
> org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:61)
> at
> org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:54)
> at
> org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:155)
> at
> org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:110)
> at
> org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:78)
> at
> org.gradle.launcher.cli.ExecuteBuildAction.run(ExecuteBuildAction.java:38)
> at
> org.gradle.launcher.exec.InProcessGradleLauncherActionExecuter.execute(InProcessGradleLauncherActionExecuter.java:39)
> at
> org.gradle.launcher.exec.InProcessGradleLauncherActionExecuter.execute(InProcessGradleLauncherActionExecuter.java:25)
> at org.gradle.launcher.cli.RunBuildAction.run(RunBuildAction.java:50)
> at org.gradle.launcher.cli.ActionAdapter.execute(ActionAdapter.java:30)
> at org.gradle.launcher.cli.ActionAdapter.execute(ActionAdapter.java:22)
> at
> org.gradle.launcher.cli.CommandLineActionFactory$ParseAndBuildAction.execute(CommandLineActionFactory.java:200)
> at
> org.gradle.launcher.cli.CommandLineActionFactory$ParseAndBuildAction.execute(CommandLineActionFactory.java:173)
> at
> org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:169)
> at
> org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:138)
> at
> org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:33)
> at
> org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:22)
> at org.gradle.launcher.Main.doAction(Main.java:48)
> at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:45)
> at org.gradle.launcher.Main.main(Main.java:39)
> at
> org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:50)
> at
> org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:32)
> at org.gradle.launcher.GradleMain.main(GradleMain.java:26)
> at
> org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:33)
> at org.gradle.wrapper.Wrapper.execute(Wrapper.java:87)
> at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:37)
> Caused by: org.gradle.api.internal.tasks.compile.CompilationFailedException:
> Compilation failed; see the compiler error output for details.
> at
> org.gradle.api.internal.tasks.compile.jdk6.Jdk6JavaCompiler.execute(Jdk6JavaCompiler.java:42)
> at
> org.gradle.api.internal.tasks.compile.jdk6.Jdk6JavaCompiler.execute(Jdk6JavaCompiler.java:33)
> at
> org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.delegateAndHandleErrors(NormalizingJavaCompiler.java:95)
> at
> org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:48)
> at
> org.gradle.api.internal.tasks.compile.NormalizingJavaCompiler.execute(NormalizingJavaCompiler.java:34)
> at
> org.gradle.api.internal.tasks.compile.DelegatingJavaCompiler.execute(DelegatingJavaCompiler.java:29)
> at
> org.gradle.api.internal.tasks.compile.DelegatingJavaCompiler.execute(DelegatingJavaCompiler.java:20)
> at
> org.gradle.api.internal.tasks.compile.IncrementalJavaCompilerSupport.execute(IncrementalJavaCompilerSupport.java:33)
> at
> org.gradle.api.internal.tasks.compile.IncrementalJavaCompilerSupport.execute(IncrementalJavaCompilerSupport.java:23)
> at org.gradle.api.tasks.compile.Compile.compile(Compile.java:60)
> at
> org.gradle.api.internal.BeanDynamicObject$MetaClassAdapter.invokeMethod(BeanDynamicObject.java:196)
> at
> org.gradle.api.internal.BeanDynamicObject.invokeMethod(BeanDynamicObject.java:102)
> at
> org.gradle.api.internal.CompositeDynamicObject.invokeMethod(CompositeDynamicObject.java:99)
> at org.gradle.api.tasks.compile.Compile_Decorated.invokeMethod(Unknown
> Source)
> at org.gradle.util.ReflectionUtil.invoke(ReflectionUtil.groovy:23)
> at
> org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$4.execute(AnnotationProcessingTaskFactory.java:150)
> at
> org.gradle.api.internal.project.taskfactory.AnnotationProcessingTaskFactory$4.execute(AnnotationProcessingTaskFactory.java:145)
> at
> org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:472)
> at
> org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:461)
> at
> org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:60)
> ... 60 more
>
>
> In Validator and Search we use this method to generate i18n exceptions.
> Looking at the current state of CoreMessageLogger we only use log messages
> (@LogMessage).
> There is no exception generated. Is this intended? How do I create an
> exception with an i18n message?
>
> And what's up with the annotation processor when using this approach anyways?
> (btw, trying to upgrade to 'org.jboss.logging:jboss-logging:3.1.1.GA' and
> 'org.jboss.logging:jboss-logging-processor:1.0.3.Final' did not help)
>
> --Hardy
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
--
st...@hibernate.org
http://hibernate.org
_______________________________________________
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
