I pulled my commit but it came out wrong (5dc04960d6ccb4f54f49c2fac83a0ccd2874fa2f merge got created). It looks like I should of rebased the commit on my local master branch before doing the pull request. It looks like git merged my change and Hardy's (from earlier today).
One thing that is worse than what I did, is rebasing after the fact (I think). Rather than making this worse, I'll wait for feedback from others that have been through this. Scott On 08/02/2011 04:50 PM, Scott Marlow wrote: > > On 08/02/2011 04:34 PM, Scott Marlow wrote: >> I'll add a security manager check to the get/set TCCL, do the manual >> test in AS7 once more and commit/merge to master. > > I'll hold off on using SM, since we don't seem to do that everywhere. I > don't want to break consistency. ;) >> >> On 08/02/2011 02:10 PM, Scott Marlow wrote: >>> https://github.com/scottmarlow/hibernate-core/commit/07d15fb39b1ac7e28546ae5a67b387772ffbe33a >>> seems to around it, by setting the TCCL to the Hibernate classloader >>> around the Antlr call "setTokenObjectClass( HqlToken.class.getName() )" >>> >>> Any objections to this change? >>> >>> On 08/02/2011 11:12 AM, Scott Marlow wrote: >>>> I created HHH-6536 for this issue. >>>> >>>> On 08/02/2011 09:46 AM, Scott Marlow wrote: >>>>> Anyone else have any ideas of what might of changed. Perhaps we were >>>>> getting lucky in Beta3 and some unrelated bug was fixed that somehow was >>>>> setting the TCCL for ANTLR. >>>>> >>>>> >>>>> On 08/01/2011 05:20 PM, Scott Marlow wrote: >>>>>> http://pastebin.com/SR3jsxGp contains the call stack for a >>>>>> ClassNotFoundException of org.hibernate.hql.internal.ast.HqlToken (from >>>>>> https://issues.jboss.org/browse/AS7-1433). The exception message isn't >>>>>> shown but the jira has that. >>>>>> >>>>>> I tried the supplied test case against Hibernate 4.0.0.Beta3 and don't >>>>>> have the same problem. Does anyone know of a Hibernate 4.0.0.Beta4 >>>>>> change that could of caused this? >>>>>> >>>>>> Perhaps we need to set the TCCL to the hibernate CL when constructing >>>>>> the HqlBaseLexer as a workaround (the Hibernate classloader depends on >>>>>> the antlr classloader module, so that should work). >>>>>> >>>>>> Whatever the solution is, I'd like to better understand what changed to >>>>>> cause this. >>>>>> >>>>>> Thanks, >>>>>> Scott >>>>>> _______________________________________________ >>>>>> hibernate-dev mailing list >>>>>> hibernate-dev@lists.jboss.org >>>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>>> >>>>> _______________________________________________ >>>>> hibernate-dev mailing list >>>>> hibernate-dev@lists.jboss.org >>>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>>> >>>> _______________________________________________ >>>> hibernate-dev mailing list >>>> hibernate-dev@lists.jboss.org >>>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >>> _______________________________________________ >>> hibernate-dev mailing list >>> hibernate-dev@lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> _______________________________________________ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
