David, perhaps you could hop on irc and we could discuss this sometime? The channel is #hibernate-dev on irc.freenode.net
I am in the midst of some pretty significant changes to how hibernate constructs SQL which will affect (and simplify I hope) the criteria code. - Steve Ebersole Project Lead http://hibernate.org st...@hibernate.org Principal Software Engineer JBoss, a division of Red Hat http://jboss.com http://redhat.com steve.ebers...@jboss.com steve.ebers...@redhat.com On Fri, 2009-01-23 at 14:58 -0500, David Mansfield wrote: > Hi, > > Although I've gotten feedback that this won't necessarily be included > as-is, or against current versions etc., since I have to update it as I > track newer Hibernate core versions (we use this modification > internally), I figure it might be of use or interest to the dev. > community. > > This is the updated patch, against 3.3.1GA > > Changes from last time include: > > * rediffed against 3.3.1 > * change to slf4j for logging > * fix the crude hack in CriteriaJoinWalker to what seems to be the > correct implementation. The issue here is complicated and not-at-all > understood by me completely. > > The method in question, generateTableAlias, seems to do (at least) two > things in the CriteriaJoinWalker, one of which is to update the internal > 'userAlias' list based on whether the Joinable 'consumesEntityAlias'. > This behavior needed to remain completely unmodified, which my previous > patch did not do. However, the reason I needed to modify this is that > some Joinables which DO NOT 'conumeEntityAlias' still need to provide an > SQL alias for the table. > > Deciding which ones, exactly, need to do this was complicated, and I'm > not sure this is currently correct. > > However, it now passes the test suite, which it didn't before. > > Thanks, > David > _______________________________________________ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev _______________________________________________ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
