It's just a slight shame to now be debugging 3.81 instead of 4.
Regards,
Tim
On 16 October 2015 at 09:27, Mark Galeck <mark_gal...@pacbell.net> wrote:
> Make 3.81 segfaults if "goto slow" is inserted just before line 2340:
>
> if (shell == 0)
> shell = default_shell;
>
>
> because then, the following line
>
> shell = default_shell;
>
>
> is not executed and shell is still 0 at (current) line 2710:
>
> bcopy(shell, ap, shell_len);
>
>
> The next suitable place to put "goto slow" is after line 2391. However, when
> I do that, again I get a segfault at (current) line 2710, even though shell
> appears to be legitimate. In fact, if I do
>
> printf("%p\n", shell);
>
> that segfaults too (!). This is bizarre and I am not sure what to think of
> it.
>
>
>
>
> So I decided to punt and study the code some more, and decided that the least
> amount of change I need is to comment out line 2625:
>
> return new_argv;
>
>
> But, when I try that, I get an assert fault on line 2412:
>
> assert (ap <= end);
>
> Again, as above, logically this does not seem to be possible :)
>
>
> So that is where I am stuck right now. Just trying to always go to shell on
> each recipe line and not optimize that out. If somebody knows why the above
> approaches don't seem to work please tell me.
>
>
>
>
> I have to explain. I am a programmer just like all of you and I don't like
> to say "help me understand this code" - we all know it is our job to grok
> code.
>
> The only excuse I have, is that the said "code" is awful, and not just
> because of heavy use of "goto". I have a MS in Comp Science and every
> professor I had would flunk me for this code. I have 25 years of experience
> as a software engineer and every boss I had who reviewed code, would not
> approve this code.
>
> Here. Please don't be offended that I criticize the code you possibly wrote.
> I did not mean to. I just want to excuse why I find it necessary to ask you
> to help me.
>
>
>
> Mark
>
> _______________________________________________
> Help-make mailing list
> Help-make@gnu.org
> https://lists.gnu.org/mailman/listinfo/help-make
--
You could help some brave and decent people to have access to
uncensored news by making a donation at:
http://www.thezimbabwean.co.uk/friends/
_______________________________________________
Help-make mailing list
Help-make@gnu.org
https://lists.gnu.org/mailman/listinfo/help-make
